fix: validate universe domain input to prevent SSRF credential leak#472
Open
adilburaksen wants to merge 1 commit into
Open
fix: validate universe domain input to prevent SSRF credential leak#472adilburaksen wants to merge 1 commit into
adilburaksen wants to merge 1 commit into
Conversation
…leak The `universe` input is interpolated directly into the Cloud Functions API endpoint (`https://cloudfunctions.${universe}/v2`). A value carrying URL syntax can redirect the credentialed request — including the GCP access token in the Authorization header — to an attacker-controlled host (e.g. `attacker.com#` truncates the real host via the fragment delimiter). Add `validateUniverse` (src/util.ts) which requires a well-formed DNS hostname (no scheme, path, port, userinfo, query, or fragment) and call it from run(). This blocks URL-injection payloads while still accepting any legitimate universe — googleapis.com, Trusted Partner Cloud, and Google Distributed Cloud domains — without an allowlist that would break sovereign deployments.
adilburaksen
force-pushed
the
fix/universe-ssrf-validation
branch
from
f67a395 to
203ffe4
Compare
Author
|
Updated this PR based on further review:
Companion fix: google-github-actions/upload-cloud-storage#404. Happy to address any review feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
universeinput is interpolated directly into the Cloud Functions API endpoint:Setting
universe: attacker.comroutes all API calls — including Bearer GCP access tokens — tocloudfunctions.attacker.com.Fix
Validates
universeagainst known-safe patterns before use:Allows
googleapis.com(default) and Trusted Partner Cloud subdomains likeus-central1.rep.googleapis.com. Blocks arbitrary hostnames.Related
Companion PR for
upload-cloud-storage: google-github-actions/upload-cloud-storage#404Same class, same root cause in
expandUniverseEndpoints.